Bluetooth: Add check for accidentally generating a debug key (6c0dcc50) · Commits · 戴 / test

It is very unlikely, but to have a 100% guarantee of the generated key type we need to reject any keys which happen to match the debug key. Signed-off-by:

Johan Hedberg <johan.hedberg@intel.com> Signed-off-by:

Marcel Holtmann <marcel@holtmann.org>

net/bluetooth/smp.c

+11 −3

Original line number	Diff line number	Diff line
		@@ -1399,10 +1399,18 @@ static u8 sc_send_public_key(struct smp_chan *smp)
		{
		BT_DBG("");

		while (true) {
		/* Generate local key pair for Secure Connections */
		if (!ecc_make_key(smp->local_pk, smp->local_sk))
		return SMP_UNSPECIFIED;

		/* This is unlikely, but we need to check that we didn't
		* accidentially generate a debug key.
		*/
		if (memcmp(smp->local_sk, debug_sk, 32))
		break;
		}

		BT_DBG("Local Public Key X: %32phN", smp->local_pk);
		BT_DBG("Local Public Key Y: %32phN", &smp->local_pk[32]);
		BT_DBG("Local Private Key: %32phN", smp->local_sk);

Admin message