soc: aspeed-lpc-ctrl: Fail probe of lpc-ctrl if reserved memory is not aligned (6bf4ddbe) · Commits · 戴 / test

Alignment is a hardware constraint of the LPC2AHB bridge, and misaligned reserved memory will present as corrupted data. Signed-off-by:

drivers/soc/aspeed/aspeed-lpc-ctrl.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -4,6 +4,7 @@
		*/

		#include <linux/clk.h>
		#include <linux/log2.h>
		#include <linux/mfd/syscon.h>
		#include <linux/miscdevice.h>
		#include <linux/mm.h>
		@@ -241,6 +242,18 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)

		lpc_ctrl->mem_size = resource_size(&resm);
		lpc_ctrl->mem_base = resm.start;

		if (!is_power_of_2(lpc_ctrl->mem_size)) {
		dev_err(dev, "Reserved memory size must be a power of 2, got %u\n",
		(unsigned int)lpc_ctrl->mem_size);
		return -EINVAL;
		}

		if (!IS_ALIGNED(lpc_ctrl->mem_base, lpc_ctrl->mem_size)) {
		dev_err(dev, "Reserved memory must be naturally aligned for size %u\n",
		(unsigned int)lpc_ctrl->mem_size);
		return -EINVAL;
		}
		}

		lpc_ctrl->regmap = syscon_node_to_regmap(