Commit 6bf18cd3 authored Nov 10, 2016 by Andreas Dilger Committed by Greg Kroah-Hartman Nov 14, 2016

staging: lustre: mdc: remove console spew from mdc_ioc_fid2path



In some cases with a very long pathname, such as with sanity.sh
test_154c, mdc_ioc_fid2path() would spew long debug messages to
the log, because libcfs_debug_vmsg2() refuses to log messages over
one page in size.

Truncate the debug message to only log the last 512 characters
of the pathname, which is sufficient for most debugging, saves a
bit of space in the debug log, and will prevent the debug logging
from printing to the console in the first place.

Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1095
Reviewed-on: http://review.whamcloud.com/17078


Reviewed-by: Jian Yu <jian.yu@intel.com>
Reviewed-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7da42db8

drivers/staging/lustre/lustre/mdc/mdc_request.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -1453,8 +1453,11 @@ static int mdc_ioc_fid2path(struct obd_export exp, struct getinfo_fid2path gf)
		goto out;
		}

		CDEBUG(D_IOCTL, "path get "DFID" from %llu #%d\n%s\n",
		PFID(&gf->gf_fid), gf->gf_recno, gf->gf_linkno, gf->gf_path);
		CDEBUG(D_IOCTL, "path got " DFID " from %llu #%d: %s\n",
		PFID(&gf->gf_fid), gf->gf_recno, gf->gf_linkno,
		gf->gf_pathlen < 512 ? gf->gf_path :
		/* only log the last 512 characters of the path */
		gf->gf_path + gf->gf_pathlen - 512);

		out:
		kfree(key);

Admin message