Commit 6bd2a42a authored Jun 04, 2019 by Colin Ian King Committed by Miquel Raynal Jun 27, 2019

mtd: rawnand: gpmi: remove double assignment to block_size



The variable block_size is being assigned to itself and to
geo->ecc_chunk_size.  Clean up the double assignment by removing
the assignment to itself.

Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

parent 3054354f

drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1428,7 +1428,7 @@ static void gpmi_bch_layout_std(struct gpmi_nand_data *this)
		struct bch_geometry *geo = &this->bch_geometry;
		unsigned int ecc_strength = geo->ecc_strength >> 1;
		unsigned int gf_len = geo->gf_len;
		unsigned int block_size = block_size = geo->ecc_chunk_size;
		unsigned int block_size = geo->ecc_chunk_size;

		this->bch_flashlayout0 =
		BF_BCH_FLASH0LAYOUT0_NBLOCKS(geo->ecc_chunk_count - 1) \|

Admin message