Commit 6bc85dd5 authored by Himanshu Madhani's avatar Himanshu Madhani Committed by Nicholas Bellinger
Browse files

qla2xxx: Remove msleep in qlt_send_term_exchange 



Remove unnecessary msleep from qlt_send_term_exchange as it
adds latency of 250 msec while sending terminate exchange to
an aborted task.

Cc: <stable@vger.kernel.org> # v3.18+
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: default avatarGiridhar Malavali <giridhar.malavali@qlogic.com>
Reviewed-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent e5fdee87

drivers/scsi/qla2xxx/qla_target.c

+7 −6
Original line number Diff line number Diff line
@@ -2713,7 +2713,7 @@ static int __qlt_send_term_exchange(struct scsi_qla_host *vha, 
static void qlt_send_term_exchange(struct scsi_qla_host *vha,

	struct qla_tgt_cmd *cmd, struct atio_from_isp *atio, int ha_locked)

{

	unsigned long flags;

	unsigned long flags = 0;

	int rc;



	if (qlt_issue_marker(vha, ha_locked) < 0)
@@ -2729,17 +2729,18 @@ static void qlt_send_term_exchange(struct scsi_qla_host *vha, 
	rc = __qlt_send_term_exchange(vha, cmd, atio);

	if (rc == -ENOMEM)

		qlt_alloc_qfull_cmd(vha, atio, 0, 0);

	spin_unlock_irqrestore(&vha->hw->hardware_lock, flags);



done:

	if (cmd && ((cmd->state != QLA_TGT_STATE_ABORTED) ||

	    !cmd->cmd_sent_to_fw)) {

		if (!ha_locked && !in_interrupt())

			msleep(250); /* just in case */



		if (cmd->sg_mapped)

			qlt_unmap_sg(vha, cmd);

		vha->hw->tgt.tgt_ops->free_cmd(cmd);

	}



	if (!ha_locked)

		spin_unlock_irqrestore(&vha->hw->hardware_lock, flags);



	return;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE