Commit 6bbb614e authored Feb 27, 2015 by Daniel Borkmann Committed by Ingo Molnar Feb 28, 2015

x86/mm: Unexport set_memory_ro() and set_memory_rw()



This effectively unexports set_memory_ro() and set_memory_rw()
functions, and thus reverts:

  a03352d2 ("x86: export set_memory_ro and set_memory_rw").

They have been introduced for debugging purposes in e1000e, but
no module user is in mainline kernel (anymore?) and we
explicitly do not want modules to use these functions, as they
i.e. protect eBPF (interpreted & JIT'ed) images from malicious
modifications or bugs.

Outside of eBPF scope, I believe also other set_memory_*()
functions should be unexported on x86 for modules.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Bruce Allan <bruce.w.allan@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: davem@davemloft.net
Link: http://lkml.kernel.org/r/a064393a0a5d319eebde5c761cfd743132d4f213.1425040940.git.daniel@iogearbox.net


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 954e12f7

arch/x86/mm/pageattr.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1654,13 +1654,11 @@ int set_memory_ro(unsigned long addr, int numpages)
		{
		return change_page_attr_clear(&addr, numpages, __pgprot(_PAGE_RW), 0);
		}
		EXPORT_SYMBOL_GPL(set_memory_ro);

		int set_memory_rw(unsigned long addr, int numpages)
		{
		return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_RW), 0);
		}
		EXPORT_SYMBOL_GPL(set_memory_rw);

		int set_memory_np(unsigned long addr, int numpages)
		{

Admin message