ASoC: SOF: loader: fix snd_sof_fw_parse_ext_data (6bb03c21) · Commits · 戴 / test

An error occurs during parsing more than one ext_data from the mailbox, because of invalid data offset handling. Fix by removing the incorrect duplicate increment of the offset. The return value is also reset in the switch case. This does not change the behavior but improves readability - there is no longer a need to check what the return value of get_ext_windows is. Signed-off-by:

Karol Trzcinski <karolx.trzcinski@linux.intel.com> Signed-off-by:

Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com> Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20191210004854.16845-4-pierre-louis.bossart@linux.intel.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/sof/loader.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -50,8 +50,7 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)

		while (ext_hdr->hdr.cmd == SOF_IPC_FW_READY) {
		/* read in ext structure */
		offset += sizeof(*ext_hdr);
		snd_sof_dsp_block_read(sdev, bar, offset,
		snd_sof_dsp_block_read(sdev, bar, offset + sizeof(*ext_hdr),
		(void )((u8 )ext_data + sizeof(*ext_hdr)),
		ext_hdr->hdr.size - sizeof(*ext_hdr));

		@@ -61,6 +60,7 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
		/* process structure data */
		switch (ext_hdr->type) {
		case SOF_IPC_EXT_DMA_BUFFER:
		ret = 0;
		break;
		case SOF_IPC_EXT_WINDOW:
		ret = get_ext_windows(sdev, ext_hdr);
		@@ -68,6 +68,7 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
		default:
		dev_warn(sdev->dev, "warning: unknown ext header type %d size 0x%x\n",
		ext_hdr->type, ext_hdr->hdr.size);
		ret = 0;
		break;
		}

Admin message