Commit 6ba99038 authored Nov 15, 2018 by Michael Chan Committed by David S. Miller Nov 15, 2018

bnxt_en: Fix RSS context allocation.

Recent commit has added the reservation of RSS context. This requires
bnxt_hwrm_vnic_qcaps() to be called before allocating any RSS contexts.
The bnxt_hwrm_vnic_qcaps() call sets up proper flags that will
determine how many RSS contexts to allocate to support NTUPLE.

This causes a regression that too many RSS contexts are being reserved
and causing resource shortage when enabling many VFs. Fix it by calling
bnxt_hwrm_vnic_qcaps() earlier.

Fixes: 41e8d798 ("bnxt_en: Modify the ring reservation functions for 57500 series chips.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f8504f4c

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -10087,6 +10087,7 @@ static int bnxt_init_one(struct pci_dev pdev, const struct pci_device_id ent)
		}

		bnxt_hwrm_func_qcfg(bp);
		bnxt_hwrm_vnic_qcaps(bp);
		bnxt_hwrm_port_led_qcaps(bp);
		bnxt_ethtool_init(bp);
		bnxt_dcb_init(bp);
		@@ -10120,7 +10121,6 @@ static int bnxt_init_one(struct pci_dev pdev, const struct pci_device_id ent)
		VNIC_RSS_CFG_REQ_HASH_TYPE_UDP_IPV6;
		}

		bnxt_hwrm_vnic_qcaps(bp);
		if (bnxt_rfs_supported(bp)) {
		dev->hw_features \|= NETIF_F_NTUPLE;
		if (bnxt_rfs_capable(bp)) {

Admin message