Commit 6ba55716 authored by Michael Ellerman's avatar Michael Ellerman
Browse files

powerpc/nmi: Add an API for sending "safe" NMIs 



Currently the options we have for sending NMIs are not necessarily
safe, that is they can potentially interrupt a CPU in a
non-recoverable region of code, meaning the kernel must then panic().

But we'd like to use smp_send_nmi_ipi() to do cross-CPU calls in
situations where we don't want to risk a panic(), because it doesn't
have the requirement that interrupts must be enabled like
smp_call_function().

So add an API for the caller to indicate that it wants to use the NMI
infrastructure, but doesn't want to do anything "unsafe".

Currently that is implemented by not actually calling cause_nmi_ipi(),
instead falling back to an IPI. In future we can pass the safe
parameter down to cause_nmi_ipi() and the individual backends can
potentially take it into account before deciding what to do.

Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Reviewed-by: default avatarNicholas Piggin <npiggin@gmail.com>
parent 7b08729c

arch/powerpc/include/asm/smp.h

+1 −0
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ struct smp_ops_t { 


extern void smp_flush_nmi_ipi(u64 delay_us);

extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us);

extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us);

extern void smp_send_debugger_break(void);

extern void start_secondary_resume(void);

extern void smp_generic_give_timebase(void);

arch/powerpc/kernel/smp.c

+15 −5
Original line number Diff line number Diff line
@@ -430,9 +430,9 @@ out: 
	return ret;

}



static void do_smp_send_nmi_ipi(int cpu)

static void do_smp_send_nmi_ipi(int cpu, bool safe)

{

	if (smp_ops->cause_nmi_ipi && smp_ops->cause_nmi_ipi(cpu))

	if (!safe && smp_ops->cause_nmi_ipi && smp_ops->cause_nmi_ipi(cpu))

		return;



	if (cpu >= 0) {
@@ -472,7 +472,7 @@ void smp_flush_nmi_ipi(u64 delay_us) 
 * - delay_us > 0 is the delay before giving up waiting for targets to

 *   enter the handler, == 0 specifies indefinite delay.

 */

int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us)

int __smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us, bool safe)

{

	unsigned long flags;

	int me = raw_smp_processor_id();
@@ -505,7 +505,7 @@ int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us) 
	nmi_ipi_busy_count++;

	nmi_ipi_unlock();



	do_smp_send_nmi_ipi(cpu);

	do_smp_send_nmi_ipi(cpu, safe);



	while (!cpumask_empty(&nmi_ipi_pending_mask)) {

		udelay(1);
@@ -527,6 +527,16 @@ int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us) 


	return ret;

}



int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us)

{

	return __smp_send_nmi_ipi(cpu, fn, delay_us, false);

}



int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us)

{

	return __smp_send_nmi_ipi(cpu, fn, delay_us, true);

}

#endif /* CONFIG_NMI_IPI */



#ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST
@@ -570,7 +580,7 @@ void crash_send_ipi(void (*crash_ipi_callback)(struct pt_regs *)) 
			 * entire NMI dance and waiting for

			 * cpus to clear pending mask, etc.

			 */

			do_smp_send_nmi_ipi(cpu);

			do_smp_send_nmi_ipi(cpu, false);

		}

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE