Commit 6ba2fd39 authored Dec 04, 2019 by Alexandre Torgue Committed by Linus Walleij Dec 13, 2019

pinctrl: pinmux: fix a possible null pointer in pinmux_can_be_used_for_gpio



This commit adds a check on ops pointer to avoid a kernel panic when
ops->strict is used. Indeed, on some pinctrl driver (at least for
pinctrl-stmfx) the pinmux ops is not implemented. Let's assume than gpio
can be used in this case.

Fixes: 472a61e7 ("pinctrl/gpio: Take MUX usage into account")
Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Link: https://lore.kernel.org/r/20191204144106.10876-1-alexandre.torgue@st.com


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent eb45f211

drivers/pinctrl/pinmux.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -85,7 +85,7 @@ bool pinmux_can_be_used_for_gpio(struct pinctrl_dev *pctldev, unsigned pin)
		const struct pinmux_ops *ops = pctldev->desc->pmxops;

		/* Can't inspect pin, assume it can be used */
		if (!desc)
		if (!desc \|\| !ops)
		return true;

		if (ops->strict && desc->mux_usecount)

Admin message