Commit 6b9ab1cf authored Aug 01, 2019 by Chuhong Yuan Committed by Jonathan Cameron Aug 05, 2019

iio: tsl2772: Use devm_add_action_or_reset



Use devm_add_action_or_reset to remove the call to
tsl2772_disable_regulators_action to simplify the error path.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Reviewed-by: Brian Masney <masneyb@onstation.org>
Tested-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 7c279229

drivers/iio/light/tsl2772.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1807,10 +1807,10 @@ static int tsl2772_probe(struct i2c_client *clientp,
		return PTR_ERR(chip->vdd_supply);
		}

		ret = devm_add_action(&clientp->dev, tsl2772_disable_regulators_action,
		ret = devm_add_action_or_reset(&clientp->dev,
		tsl2772_disable_regulators_action,
		chip);
		if (ret < 0) {
		tsl2772_disable_regulators_action(chip);
		dev_err(&clientp->dev, "Failed to setup regulator cleanup action %d\n",
		ret);
		return ret;

Admin message