Commit 6b8cc330 authored Apr 09, 2013 by Josef Ahmad Committed by Mark Brown Apr 10, 2013

spi-gpio: init CS before spi_bitbang_setup()



spi_bitbang_setup() deasserts the chip select line to initialise
the device. The chip select GPIO line is obtained from
spi_gpio->cs_gpios[] private data.
Currently, devices that are not registered under devicetree
environment will call into spi_bitbang_setup() with stale
cs_gpios[].

This patch ensures spi_gpio->cs_gpios[] is always initialised prior
to calling spi_bitbang_setup().

Reviewed-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Josef Ahmad <josef.ahmad@intel.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent c3e2aa86

drivers/spi/spi-gpio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -265,9 +265,9 @@ static int spi_gpio_setup(struct spi_device *spi)
		}
		}
		if (!status) {
		status = spi_bitbang_setup(spi);
		/* in case it was initialized from static board data */
		spi_gpio->cs_gpios[spi->chip_select] = cs;
		status = spi_bitbang_setup(spi);
		}

		if (status) {

Admin message