audit: change unnecessary globals into statics (6b87024f) · Commits · 戴 / test

Variables sig_pid, audit_sig_uid and audit_sig_sid are only used in the audit.c file across the kernel Hence it appears no reason for declaring them as globals This patch removes their global declarations from the .h file and change them into static in the .c file. Signed-off-by:

Jules Irenge <jbi.octave@gmail.com> Signed-off-by:

Paul Moore <paul@paul-moore.com>

kernel/audit.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -123,9 +123,9 @@ static u32 audit_backlog_limit = 64;
		static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;

		/* The identity of the user shutting down the audit system. */
		kuid_t audit_sig_uid = INVALID_UID;
		pid_t audit_sig_pid = -1;
		u32 audit_sig_sid = 0;
		static kuid_t audit_sig_uid = INVALID_UID;
		static pid_t audit_sig_pid = -1;
		static u32 audit_sig_sid = 0;

		/* Records can be lost in several ways:
		0) [suppressed in audit_alloc]

kernel/audit.h

+0 −4

Original line number	Diff line number	Diff line
		@@ -327,10 +327,6 @@ static inline int audit_signal_info_syscall(struct task_struct *t)

		extern char audit_unpack_string(void bufp, size_t remain, size_t len);

		extern pid_t audit_sig_pid;
		extern kuid_t audit_sig_uid;
		extern u32 audit_sig_sid;

		extern int audit_filter(int msgtype, unsigned int listtype);

		extern void audit_ctl_lock(void);

Admin message