PCI: designware-ep: Use aligned ATU window for raising MSI interrupts (6b733030) · Commits · 戴 / test

Certain platforms like K2G reguires the outbound ATU window to be aligned. The alignment size is already present in mem->page_size. Use the alignment size present in mem->page_size to configure an aligned ATU window. In order to raise an interrupt, CPU has to write to address offset from the start of the window unlike before where writes were always to the beginning of the ATU window. Signed-off-by:

Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by:

Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

drivers/pci/controller/dwc/pcie-designware-ep.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -397,6 +397,7 @@ int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no,
		{
		struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
		struct pci_epc *epc = ep->epc;
		unsigned int aligned_offset;
		u16 msg_ctrl, msg_data;
		u32 msg_addr_lower, msg_addr_upper, reg;
		u64 msg_addr;
		@@ -422,13 +423,15 @@ int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no,
		reg = ep->msi_cap + PCI_MSI_DATA_32;
		msg_data = dw_pcie_readw_dbi(pci, reg);
		}
		msg_addr = ((u64) msg_addr_upper) << 32 \| msg_addr_lower;
		aligned_offset = msg_addr_lower & (epc->mem->page_size - 1);
		msg_addr = ((u64)msg_addr_upper) << 32 \|
		(msg_addr_lower & ~aligned_offset);
		ret = dw_pcie_ep_map_addr(epc, func_no, ep->msi_mem_phys, msg_addr,
		epc->mem->page_size);
		if (ret)
		return ret;

		writel(msg_data \| (interrupt_num - 1), ep->msi_mem);
		writel(msg_data \| (interrupt_num - 1), ep->msi_mem + aligned_offset);

		dw_pcie_ep_unmap_addr(epc, func_no, ep->msi_mem_phys);

Admin message