Commit 6b5f02f3 authored by Sam Ravnborg's avatar Sam Ravnborg Committed by David S. Miller
Browse files

sparc32: fix sparse warnings in tadpole.c 



Fix following warnings:
tadpole.c:21:6: warning: symbol 'cpu_pwr_save' was not declared. Should it be static?
tadpole.c:101:13: warning: symbol 'clock_stop_probe' was not declared. Should it be static?

This actually revealed that cpu_pwr_save is only assigned.
It was left static with a TODO comment for now - this should be cleaned up later.

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8885ec7c

arch/sparc/kernel/devices.c

+1 −1
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ 
#include <asm/cpu_type.h>

#include <asm/setup.h>



extern void clock_stop_probe(void); /* tadpole.c */

#include "kernel.h"



static char *cpu_mid_prop(void)

{

arch/sparc/kernel/kernel.h

+3 −0
Original line number Diff line number Diff line
@@ -113,6 +113,9 @@ asmlinkage int do_sys_sigstack(struct sigstack __user *ssptr, 
/* windows.c */

void try_to_clear_window_buffer(struct pt_regs *regs, int who);



/* tadpole.c */

void __init clock_stop_probe(void);



#else /* CONFIG_SPARC32 */

#endif /* CONFIG_SPARC32 */

#endif /* !(__SPARC_KERNEL_H) */

arch/sparc/kernel/tadpole.c

+5 −1
Original line number Diff line number Diff line
@@ -12,13 +12,17 @@ 
#include <asm/oplib.h>

#include <asm/io.h>



#include "kernel.h"



#define MACIO_SCSI_CSR_ADDR	0x78400000

#define MACIO_EN_DMA		0x00000200

#define CLOCK_INIT_DONE		1



static int clk_state;

static volatile unsigned char *clk_ctrl;

void (*cpu_pwr_save)(void);



/* TODO - cpu_pwr_save is only assigned - cleanup potential. */

static void (*cpu_pwr_save)(void);



static inline unsigned int ldphys(unsigned int addr)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE