Commit 6b5472d4 authored Sep 09, 2020 by Zhang Changzhong Committed by David S. Miller Sep 09, 2020

net: stmmac: dwmac-intel-plat: remove redundant null check before clk_disable_unprepare()



Because clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter, so the additional checks are unnecessary, just
remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a0d48518

drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -149,9 +149,7 @@ static int intel_eth_plat_probe(struct platform_device *pdev)

		ret = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
		if (ret) {
		if (dwmac->tx_clk)
		clk_disable_unprepare(dwmac->tx_clk);

		goto err_remove_config_dt;
		}

		@@ -169,8 +167,6 @@ static int intel_eth_plat_remove(struct platform_device *pdev)
		int ret;

		ret = stmmac_pltfr_remove(pdev);

		if (dwmac->tx_clk)
		clk_disable_unprepare(dwmac->tx_clk);

		return ret;

Admin message