Commit 6b41030f authored Apr 29, 2020 by Vladimir Murzin Committed by Vinod Koul May 13, 2020

dmaengine: dmatest: Restore default for channel



In case of dmatest is built-in and no channel was configured test
doesn't run with:

dmatest: Could not start test, no channels configured

Even though description to "channel" parameter claims that default is
any.

Add default channel back as it used to be rather than reject test with
no channel configuration.

Fixes: d53513d5 ("dmaengine: dmatest: Add support for multi channel testing)
Reported-by: Dijil Mohan <Dijil.Mohan@arm.com>
Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
Link: https://lore.kernel.org/r/20200429071522.58148-1-vladimir.murzin@arm.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 4f302642

drivers/dma/dmatest.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -1166,10 +1166,11 @@ static int dmatest_run_set(const char val, const struct kernel_param kp)
		mutex_unlock(&info->lock);
		return ret;
		} else if (dmatest_run) {
		if (is_threaded_test_pending(info))
		if (!is_threaded_test_pending(info)) {
		pr_info("No channels configured, continue with any\n");
		add_threaded_test(info);
		}
		start_threaded_tests(info);
		else
		pr_info("Could not start test, no channels configured\n");
		} else {
		stop_threaded_test(info);
		}

Admin message