Commit 6b19b660 authored Nov 19, 2014 by Arnaud Ebalard Committed by Guenter Roeck Nov 19, 2014

hwmon: (g762) fix call to devm_hwmon_device_register_with_groups()



g762_remove() needs to first call hwmon_device_unregister() and then
g762_of_clock_disable(). For that reason, it is not possible to
convert it to devm_hwmon_device_register_with_groups() and the
the non device managed version must be used.

This is correctly stated in commit message for 398e16db ("hwmon:
(g762) Convert to hwmon_device_register_with_groups") but the
associated changes do in fact introduce a call to the device managed
version of the function.

This patch fixes that typo by switching to the non devm_ version.

Fixes: 398e16db ("hwmon: (g762) Convert to hwmon_device_register_with_groups")
Cc: stable@vger.kernel.org (3.17+)
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent fc14f9c1

drivers/hwmon/g762.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1084,10 +1084,8 @@ static int g762_probe(struct i2c_client client, const struct i2c_device_id id)
		if (ret)
		goto clock_dis;

		data->hwmon_dev = devm_hwmon_device_register_with_groups(dev,
		client->name,
		data,
		g762_groups);
		data->hwmon_dev = hwmon_device_register_with_groups(dev, client->name,
		data, g762_groups);
		if (IS_ERR(data->hwmon_dev)) {
		ret = PTR_ERR(data->hwmon_dev);
		goto clock_dis;

Admin message