Commit 6b124d8d authored by Steven Whitehouse's avatar Steven Whitehouse
Browse files

[GFS2] Only set inode flags when required 



We were setting the inode flags from GFS2's flags far too often, even when they
couldn't possibly have changed. This patch reduces the amount of flag
setting going on so that we do it only when the inode is read in or
when the flags have changed. The create case is covered by the "when
the inode is read in" case.

This also fixes a bug where we didn't set S_SYNC correctly.

Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent 2ca99501

fs/gfs2/inode.c

+1 −10
Original line number Diff line number Diff line
@@ -54,16 +54,6 @@ void gfs2_inode_attr_in(struct gfs2_inode *ip) 
	i_size_write(inode, di->di_size);

	inode->i_blocks = di->di_blocks <<

		(GFS2_SB(inode)->sd_sb.sb_bsize_shift - GFS2_BASIC_BLOCK_SHIFT);



	if (di->di_flags & GFS2_DIF_IMMUTABLE)

		inode->i_flags |= S_IMMUTABLE;

	else

		inode->i_flags &= ~S_IMMUTABLE;



	if (di->di_flags & GFS2_DIF_APPENDONLY)

		inode->i_flags |= S_APPEND;

	else

		inode->i_flags &= ~S_APPEND;

}



static int iget_test(struct inode *inode, void *opaque)
@@ -210,6 +200,7 @@ static int gfs2_dinode_in(struct gfs2_inode *ip, const void *buf) 
	di->di_generation = be64_to_cpu(str->di_generation);



	di->di_flags = be32_to_cpu(str->di_flags);

	gfs2_set_inode_flags(&ip->i_inode);

	di->di_height = be16_to_cpu(str->di_height);



	di->di_depth = be16_to_cpu(str->di_depth);

fs/gfs2/ops_file.c

+19 −0
Original line number Diff line number Diff line
@@ -266,6 +266,24 @@ static int gfs2_get_flags(struct file *filp, u32 __user *ptr) 
	return error;

}



void gfs2_set_inode_flags(struct inode *inode)

{

	struct gfs2_inode *ip = GFS2_I(inode);

	struct gfs2_dinode_host *di = &ip->i_di;

	unsigned int flags = inode->i_flags;



	flags &= ~(S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC);

	if (di->di_flags & GFS2_DIF_IMMUTABLE)

		flags |= S_IMMUTABLE;

	if (di->di_flags & GFS2_DIF_APPENDONLY)

		flags |= S_APPEND;

	if (di->di_flags & GFS2_DIF_NOATIME)

		flags |= S_NOATIME;

	if (di->di_flags & GFS2_DIF_SYNC)

		flags |= S_SYNC;

	inode->i_flags = flags;

}



/* Flags that can be set by user space */

#define GFS2_FLAGS_USER_SET (GFS2_DIF_JDATA|			\

			     GFS2_DIF_DIRECTIO|			\
@@ -338,6 +356,7 @@ static int do_gfs2_set_flags(struct file *filp, u32 reqflags, u32 mask) 
	ip->i_di.di_flags = new_flags;

	gfs2_dinode_out(ip, bh->b_data);

	brelse(bh);

	gfs2_set_inode_flags(inode);

out_trans_end:

	gfs2_trans_end(sdp);

out:

fs/gfs2/ops_file.h

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ extern struct file gfs2_internal_file_sentinel; 
extern int gfs2_internal_read(struct gfs2_inode *ip,

			      struct file_ra_state *ra_state,

			      char *buf, loff_t *pos, unsigned size);



extern void gfs2_set_inode_flags(struct inode *inode);

extern const struct file_operations gfs2_file_fops;

extern const struct file_operations gfs2_dir_fops;

CRA Git | Maintained and supported by SUSTech CRA and CCSE