Commit 6b034e25 authored by Christian König's avatar Christian König Committed by Alex Deucher
Browse files

drm/amdgpu: limit the VM address space with older VCE FW versions 



Older VCE FW versions are buggy and can't work with 48bit address
spaces.

RFC: Should we limit the address space or just reject loading the older
VCE firmware?

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e2751493

drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

+5 −0
Original line number Diff line number Diff line
@@ -581,6 +581,11 @@ static int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file 


		vm_size = adev->vm_manager.max_pfn * AMDGPU_GPU_PAGE_SIZE;

		vm_size -= AMDGPU_VA_RESERVED_SIZE;



		/* Older VCE FW versions are buggy and can handle only 40bits */

		if (adev->vce.fw_version < AMDGPU_VCE_FW_53_45)

			vm_size = min(vm_size, 1ULL << 40);



		dev_info.virtual_address_offset = AMDGPU_VA_RESERVED_SIZE;

		dev_info.virtual_address_max =

			min(vm_size, AMDGPU_VA_HOLE_START);

drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h

+2 −0
Original line number Diff line number Diff line
@@ -30,6 +30,8 @@ 
#define AMDGPU_VCE_HARVEST_VCE0 (1 << 0)

#define AMDGPU_VCE_HARVEST_VCE1 (1 << 1)



#define AMDGPU_VCE_FW_53_45	((53 << 24) | (45 << 16))



struct amdgpu_vce {

	struct amdgpu_bo	*vcpu_bo;

	uint64_t		gpu_addr;

CRA Git | Maintained and supported by SUSTech CRA and CCSE