dmaengine: mxs-dma: convert tasklets to use new tasklet_setup() API (6afe8778) · Commits · 戴 / test

In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by:

Romain Perier <romain.perier@gmail.com> Signed-off-by:

Allen Pais <allen.lkml@gmail.com> Link: https://lore.kernel.org/r/20200831103542.305571-18-allen.lkml@gmail.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/mxs-dma.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -319,9 +319,9 @@ static dma_cookie_t mxs_dma_tx_submit(struct dma_async_tx_descriptor *tx)
		return dma_cookie_assign(tx);
		}

		static void mxs_dma_tasklet(unsigned long data)
		static void mxs_dma_tasklet(struct tasklet_struct *t)
		{
		struct mxs_dma_chan mxs_chan = (struct mxs_dma_chan ) data;
		struct mxs_dma_chan *mxs_chan = from_tasklet(mxs_chan, t, tasklet);

		dmaengine_desc_get_callback_invoke(&mxs_chan->desc, NULL);
		}
		@@ -811,8 +811,7 @@ static int __init mxs_dma_probe(struct platform_device *pdev)
		mxs_chan->chan.device = &mxs_dma->dma_device;
		dma_cookie_init(&mxs_chan->chan);

		tasklet_init(&mxs_chan->tasklet, mxs_dma_tasklet,
		(unsigned long) mxs_chan);
		tasklet_setup(&mxs_chan->tasklet, mxs_dma_tasklet);


		/* Add the channel to mxs_chan list */

Admin message