Commit 6af588fe authored by Robin Murphy's avatar Robin Murphy Committed by Joerg Roedel
Browse files

iommu: Add fast hook for getting DMA domains 



While iommu_get_domain_for_dev() is the robust way for arbitrary IOMMU
API callers to retrieve the domain pointer, for DMA ops domains it
doesn't scale well for large systems and multi-queue devices, since the
momentary refcount adjustment will lead to exclusive cacheline contention
when multiple CPUs are operating in parallel on different mappings for
the same device.

In the case of DMA ops domains, however, this refcounting is actually
unnecessary, since they already imply that the group exists and is
managed by platform code and IOMMU internals (by virtue of
iommu_group_get_for_dev()) such that a reference will already be held
for the lifetime of the device. Thus we can avoid the bottleneck by
providing a fast lookup specifically for the DMA code to retrieve the
default domain it already knows it has set up - a simple read-only
dereference plays much nicer with cache-coherency protocols.

Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Tested-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent bee60e94

drivers/iommu/iommu.c

+9 −0
Original line number Original line Diff line number Diff line
@@ -1415,6 +1415,15 @@ struct iommu_domain *iommu_get_domain_for_dev(struct device *dev) 
}

}

EXPORT_SYMBOL_GPL(iommu_get_domain_for_dev);

EXPORT_SYMBOL_GPL(iommu_get_domain_for_dev);





/*

 * For IOMMU_DOMAIN_DMA implementations which already provide their own

 * guarantees that the group and its default domain are valid and correct.

 */

struct iommu_domain *iommu_get_dma_domain(struct device *dev)

{

	return dev->iommu_group->default_domain;

}



/*

/*

 * IOMMU groups are really the natrual working unit of the IOMMU, but

 * IOMMU groups are really the natrual working unit of the IOMMU, but

 * the IOMMU API works on domains and devices.  Bridge that gap by

 * the IOMMU API works on domains and devices.  Bridge that gap by

include/linux/iommu.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -293,6 +293,7 @@ extern int iommu_attach_device(struct iommu_domain *domain, 
extern void iommu_detach_device(struct iommu_domain *domain,

extern void iommu_detach_device(struct iommu_domain *domain,

				struct device *dev);

				struct device *dev);

extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);

extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);

extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);

extern int iommu_map(struct iommu_domain *domain, unsigned long iova,

extern int iommu_map(struct iommu_domain *domain, unsigned long iova,

		     phys_addr_t paddr, size_t size, int prot);

		     phys_addr_t paddr, size_t size, int prot);

extern size_t iommu_unmap(struct iommu_domain *domain, unsigned long iova,

extern size_t iommu_unmap(struct iommu_domain *domain, unsigned long iova,

CRA Git | Maintained and supported by SUSTech CRA and CCSE