Commit 6af1f93e authored Apr 21, 2014 by Christian Engelmayer Committed by Herbert Xu Apr 28, 2014

crypto: tcrypt - Fix leak of struct aead_request in test_aead_speed()



Fix leakage of memory for struct aead_request that is allocated via
aead_request_alloc() but not released via aead_request_free().
Reported by Coverity - CID 1163869.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Tim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent a2ea6ed6

crypto/tcrypt.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -320,7 +320,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec,
		if (!req) {
		pr_err("alg: aead: Failed to allocate request for %s\n",
		algo);
		goto out;
		goto out_noreq;
		}

		i = 0;
		@@ -390,6 +390,8 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec,
		} while (*keysize);

		out:
		aead_request_free(req);
		out_noreq:
		crypto_free_aead(tfm);
		out_notfm:
		kfree(sg);

Admin message