Commit 6aed4ee9 authored Dec 14, 2009 by Ben Nizette Committed by Grant Likely Dec 17, 2009

atmel_spi: fix dma addr calculation for len > BUFFER_SIZE



If len > BUFFER_LEN and !xfer->rx_buf we end up calculating the tx buffer
address as

*tx_dma = xfer->tx_dma + xfer->len - BUFFER_SIZE;

which is constant; i.e.  we just send the last BUFFER_SIZE data over again
until we've reached the right number of bytes.

This patch gets around this by using the /requested/ length when
calculating addresses.

Note there's no way len != *plen when we calculate the rx buffer address
but conceptually we should be using *plen and I don't want someone to come
through later, see the calculations for rx and tx are different and "clean
up" back to what we had.

Signed-off-by: Ben Nizette <bn@niasdigital.com>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

parent bec0806c

drivers/spi/atmel_spi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -189,14 +189,14 @@ static void atmel_spi_next_xfer_data(struct spi_master *master,

		/* use scratch buffer only when rx or tx data is unspecified */
		if (xfer->rx_buf)
		*rx_dma = xfer->rx_dma + xfer->len - len;
		rx_dma = xfer->rx_dma + xfer->len - plen;
		else {
		*rx_dma = as->buffer_dma;
		if (len > BUFFER_SIZE)
		len = BUFFER_SIZE;
		}
		if (xfer->tx_buf)
		*tx_dma = xfer->tx_dma + xfer->len - len;
		tx_dma = xfer->tx_dma + xfer->len - plen;
		else {
		*tx_dma = as->buffer_dma;
		if (len > BUFFER_SIZE)

Admin message