Commit 6ad018e3 authored by Luc Van Oostenryck's avatar Luc Van Oostenryck Committed by Linus Torvalds
Browse files

init/: remove ineffective sparse disabling 

Sparse checking used to be disabled on init/do_mounts.c and a few related
files because "Many of the syscalls used in this file expect some of the
arguments to be __user pointers not __kernel pointers".

However since 28128c61 ("kconfig.h: Include compiler types to avoid
missed struct attributes") the checks are, in fact, not disabled anymore
because of the more early include of "linux/compiler_types.h"

So remove the now ineffective #undefery that was done to disable these
warnings, as well as the associated comment.

Link: http://lkml.kernel.org/r/20180617115355.53799-1-luc.vanoostenryck@gmail.com


Signed-off-by: default avatarLuc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 992991c0

init/do_mounts.c

+0 −10
Original line number Diff line number Diff line 
/*

 * Many of the syscalls used in this file expect some of the arguments

 * to be __user pointers not __kernel pointers.  To limit the sparse

 * noise, turn off sparse checking for this file.

 */

#ifdef __CHECKER__

#undef __CHECKER__

#warning "Sparse checking disabled for this file"

#endif



#include <linux/module.h>

#include <linux/sched.h>

#include <linux/ctype.h>

init/do_mounts_initrd.c

+0 −10
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * Many of the syscalls used in this file expect some of the arguments

 * to be __user pointers not __kernel pointers.  To limit the sparse

 * noise, turn off sparse checking for this file.

 */

#ifdef __CHECKER__

#undef __CHECKER__

#warning "Sparse checking disabled for this file"

#endif



#include <linux/unistd.h>

#include <linux/kernel.h>

#include <linux/fs.h>

init/do_mounts_md.c

+0 −10
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * Many of the syscalls used in this file expect some of the arguments

 * to be __user pointers not __kernel pointers.  To limit the sparse

 * noise, turn off sparse checking for this file.

 */

#ifdef __CHECKER__

#undef __CHECKER__

#warning "Sparse checking disabled for this file"

#endif



#include <linux/delay.h>

#include <linux/raid/md_u.h>

#include <linux/raid/md_p.h>

init/do_mounts_rd.c

+0 −10
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * Many of the syscalls used in this file expect some of the arguments

 * to be __user pointers not __kernel pointers.  To limit the sparse

 * noise, turn off sparse checking for this file.

 */

#ifdef __CHECKER__

#undef __CHECKER__

#warning "Sparse checking disabled for this file"

#endif



#include <linux/kernel.h>

#include <linux/fs.h>

#include <linux/minix_fs.h>

init/initramfs.c

+0 −10
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * Many of the syscalls used in this file expect some of the arguments

 * to be __user pointers not __kernel pointers.  To limit the sparse

 * noise, turn off sparse checking for this file.

 */

#ifdef __CHECKER__

#undef __CHECKER__

#warning "Sparse checking disabled for this file"

#endif



#include <linux/init.h>

#include <linux/fs.h>

#include <linux/slab.h>

CRA Git | Maintained and supported by SUSTech CRA and CCSE