nvme-tcp: constify nvme_tcp_mq_ops and nvme_tcp_admin_mq_ops (6acbd961) · Commits · 戴 / test

nvme_tcp_mq_ops and nvme_tcp_admin_mq_ops are never modified and can be made const to allow the compiler to put them in read-only memory. Before: text data bss dec hex filename 53102 6885 576 60563 ec93 drivers/nvme/host/tcp.o After: text data bss dec hex filename 53422 6565 576 60563 ec93 drivers/nvme/host/tcp.o Signed-off-by:

Rikard Falkeborn <rikard.falkeborn@gmail.com> Acked-by:

Sagi Grimberg <sagi@grimberg.me> Reviewed-by:

Max Gurtovoy <maxg@mellanox.com> Signed-off-by:

Christoph Hellwig <hch@lst.de> Signed-off-by:

Jens Axboe <axboe@kernel.dk>

drivers/nvme/host/tcp.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -131,8 +131,8 @@ struct nvme_tcp_ctrl {
		static LIST_HEAD(nvme_tcp_ctrl_list);
		static DEFINE_MUTEX(nvme_tcp_ctrl_mutex);
		static struct workqueue_struct *nvme_tcp_wq;
		static struct blk_mq_ops nvme_tcp_mq_ops;
		static struct blk_mq_ops nvme_tcp_admin_mq_ops;
		static const struct blk_mq_ops nvme_tcp_mq_ops;
		static const struct blk_mq_ops nvme_tcp_admin_mq_ops;
		static int nvme_tcp_try_send(struct nvme_tcp_queue *queue);

		static inline struct nvme_tcp_ctrl to_tcp_ctrl(struct nvme_ctrl ctrl)
		@@ -2338,7 +2338,7 @@ static int nvme_tcp_poll(struct blk_mq_hw_ctx *hctx)
		return queue->nr_cqe;
		}

		static struct blk_mq_ops nvme_tcp_mq_ops = {
		static const struct blk_mq_ops nvme_tcp_mq_ops = {
		.queue_rq = nvme_tcp_queue_rq,
		.complete = nvme_complete_rq,
		.init_request = nvme_tcp_init_request,
		@@ -2349,7 +2349,7 @@ static struct blk_mq_ops nvme_tcp_mq_ops = {
		.poll = nvme_tcp_poll,
		};

		static struct blk_mq_ops nvme_tcp_admin_mq_ops = {
		static const struct blk_mq_ops nvme_tcp_admin_mq_ops = {
		.queue_rq = nvme_tcp_queue_rq,
		.complete = nvme_complete_rq,
		.init_request = nvme_tcp_init_request,

Admin message