rtw88: Make some symbols static (6aca0977) · Commits · 戴 / test

Fix sparse warnings: drivers/net/wireless/realtek/rtw88/phy.c:851:4: warning: symbol 'rtw_cck_size' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/phy.c:852:4: warning: symbol 'rtw_ofdm_size' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/phy.c:853:4: warning: symbol 'rtw_ht_1s_size' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/phy.c:854:4: warning: symbol 'rtw_ht_2s_size' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/phy.c:855:4: warning: symbol 'rtw_vht_1s_size' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/phy.c:856:4: warning: symbol 'rtw_vht_2s_size' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/fw.c:11:6: warning: symbol 'rtw_fw_c2h_cmd_handle_ext' was not declared. Should it be static? drivers/net/wireless/realtek/rtw88/fw.c:50:6: warning: symbol 'rtw_fw_send_h2c_command' was not declared. Should it be static? Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/realtek/rtw88/fw.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -8,7 +8,8 @@
		#include "reg.h"
		#include "debug.h"

		void rtw_fw_c2h_cmd_handle_ext(struct rtw_dev rtwdev, struct sk_buff skb)
		static void rtw_fw_c2h_cmd_handle_ext(struct rtw_dev *rtwdev,
		struct sk_buff *skb)
		{
		struct rtw_c2h_cmd *c2h;
		u8 sub_cmd_id;
		@@ -47,7 +48,8 @@ void rtw_fw_c2h_cmd_handle(struct rtw_dev rtwdev, struct sk_buff skb)
		}
		}

		void rtw_fw_send_h2c_command(struct rtw_dev rtwdev, u8 h2c)
		static void rtw_fw_send_h2c_command(struct rtw_dev *rtwdev,
		u8 *h2c)
		{
		u8 box;
		u8 box_state;

drivers/net/wireless/realtek/rtw88/phy.c

+7 −6

Original line number	Diff line number	Diff line
		@@ -853,12 +853,13 @@ u8 rtw_vht_2s_rates[] = {
		DESC_RATEVHT2SS_MCS6, DESC_RATEVHT2SS_MCS7,
		DESC_RATEVHT2SS_MCS8, DESC_RATEVHT2SS_MCS9
		};
		u8 rtw_cck_size = ARRAY_SIZE(rtw_cck_rates);
		u8 rtw_ofdm_size = ARRAY_SIZE(rtw_ofdm_rates);
		u8 rtw_ht_1s_size = ARRAY_SIZE(rtw_ht_1s_rates);
		u8 rtw_ht_2s_size = ARRAY_SIZE(rtw_ht_2s_rates);
		u8 rtw_vht_1s_size = ARRAY_SIZE(rtw_vht_1s_rates);
		u8 rtw_vht_2s_size = ARRAY_SIZE(rtw_vht_2s_rates);

		static u8 rtw_cck_size = ARRAY_SIZE(rtw_cck_rates);
		static u8 rtw_ofdm_size = ARRAY_SIZE(rtw_ofdm_rates);
		static u8 rtw_ht_1s_size = ARRAY_SIZE(rtw_ht_1s_rates);
		static u8 rtw_ht_2s_size = ARRAY_SIZE(rtw_ht_2s_rates);
		static u8 rtw_vht_1s_size = ARRAY_SIZE(rtw_vht_1s_rates);
		static u8 rtw_vht_2s_size = ARRAY_SIZE(rtw_vht_2s_rates);
		u8 *rtw_rate_section[RTW_RATE_SECTION_MAX] = {
		rtw_cck_rates, rtw_ofdm_rates,
		rtw_ht_1s_rates, rtw_ht_2s_rates,

Admin message