Commit 6ac972dd authored Mar 13, 2019 by Julien Grall Committed by Greg Kroah-Hartman Mar 28, 2019

tty/sysrq: Convert show_lock to raw_spinlock_t



Systems which don't provide arch_trigger_cpumask_backtrace() will
invoke showacpu() from a smp_call_function() function which is invoked
with disabled interrupts even on -RT systems.

The function acquires the show_lock lock which only purpose is to
ensure that the CPUs don't print simultaneously. Otherwise the
output would clash and it would be hard to tell the output from CPUx
apart from CPUy.

On -RT the spin_lock() can not be acquired from this context. A
raw_spin_lock() is required. It will introduce the system's latency
by performing the sysrq request and other CPUs will block on the lock
until the request is done. This is okay because the user asked for a
backtrace of all active CPUs and under "normal circumstances in
production" this path should not be triggered.

Signed-off-by: Julien Grall <julien.grall@arm.com>
[bigeasy@linuxtronix.de: commit description]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6b77908f

drivers/tty/sysrq.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -208,7 +208,7 @@ static struct sysrq_key_op sysrq_showlocks_op = {
		#endif

		#ifdef CONFIG_SMP
		static DEFINE_SPINLOCK(show_lock);
		static DEFINE_RAW_SPINLOCK(show_lock);

		static void showacpu(void *dummy)
		{
		@@ -218,10 +218,10 @@ static void showacpu(void *dummy)
		if (idle_cpu(smp_processor_id()))
		return;

		spin_lock_irqsave(&show_lock, flags);
		raw_spin_lock_irqsave(&show_lock, flags);
		pr_info("CPU%d:\n", smp_processor_id());
		show_stack(NULL, NULL);
		spin_unlock_irqrestore(&show_lock, flags);
		raw_spin_unlock_irqrestore(&show_lock, flags);
		}

		static void sysrq_showregs_othercpus(struct work_struct *dummy)

Admin message