Commit 6ab10b76 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/kms: Nuke dirty_info property 



It was added way back together with the dirty_fb ioctl, but neither
generic xfree86-modesetting nor the vmware driver use it. Everyone is
supposed to just unconditionally call the dirtyfb when they do
frontbuffer rendering.

And since unused uabi is bad uabi (there's reasons we require open
source userspace for everything) let's nuke this.

For reference see

commit 884840aa
Author: Jakob Bornecrantz <jakob@vmware.com>
Date:   Thu Dec 3 23:25:47 2009 +0000

    drm: Add dirty ioctl and property

Cc: Jakob Bornecrantz <jakob@vmware.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Sinclair Yeh <syeh@vmware.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Acked-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1471034937-651-9-git-send-email-daniel.vetter@ffwll.ch
parent ecfd8efc

drivers/gpu/drm/drm_crtc.c

+0 −31
Original line number Diff line number Diff line
@@ -136,12 +136,6 @@ static const struct drm_prop_enum_list drm_tv_subconnector_enum_list[] = { 
DRM_ENUM_NAME_FN(drm_get_tv_subconnector_name,

		 drm_tv_subconnector_enum_list)



static const struct drm_prop_enum_list drm_dirty_info_enum_list[] = {

	{ DRM_MODE_DIRTY_OFF,      "Off"      },

	{ DRM_MODE_DIRTY_ON,       "On"       },

	{ DRM_MODE_DIRTY_ANNOTATE, "Annotate" },

};



struct drm_conn_prop_enum_list {

	int type;

	const char *name;
@@ -1887,31 +1881,6 @@ int drm_mode_create_aspect_ratio_property(struct drm_device *dev) 
}

EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);



/**

 * drm_mode_create_dirty_property - create dirty property

 * @dev: DRM device

 *

 * Called by a driver the first time it's needed, must be attached to desired

 * connectors.

 */

int drm_mode_create_dirty_info_property(struct drm_device *dev)

{

	struct drm_property *dirty_info;



	if (dev->mode_config.dirty_info_property)

		return 0;



	dirty_info =

		drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,

				    "dirty",

				    drm_dirty_info_enum_list,

				    ARRAY_SIZE(drm_dirty_info_enum_list));

	dev->mode_config.dirty_info_property = dirty_info;



	return 0;

}

EXPORT_SYMBOL(drm_mode_create_dirty_info_property);



/**

 * drm_mode_create_suggested_offset_properties - create suggests offset properties

 * @dev: DRM device

drivers/gpu/drm/udl/udl_connector.c

+0 −3
Original line number Diff line number Diff line
@@ -150,8 +150,5 @@ int udl_connector_init(struct drm_device *dev, struct drm_encoder *encoder) 
	drm_connector_register(connector);

	drm_mode_connector_attach_encoder(connector, encoder);



	drm_object_attach_property(&connector->base,

				      dev->mode_config.dirty_info_property,

				      1);

	return 0;

}

drivers/gpu/drm/udl/udl_modeset.c

+0 −2
Original line number Diff line number Diff line
@@ -441,8 +441,6 @@ int udl_modeset_init(struct drm_device *dev) 


	dev->mode_config.funcs = &udl_mode_funcs;



	drm_mode_create_dirty_info_property(dev);



	udl_crtc_init(dev);



	encoder = udl_encoder_init(dev);

drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c

+0 −9
Original line number Diff line number Diff line
@@ -376,9 +376,6 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit) 


	drm_mode_crtc_set_gamma_size(crtc, 256);



	drm_object_attach_property(&connector->base,

				   dev->mode_config.dirty_info_property,

				   1);

	drm_object_attach_property(&connector->base,

				   dev_priv->hotplug_mode_update_property, 1);

	drm_object_attach_property(&connector->base,
@@ -421,10 +418,6 @@ int vmw_kms_ldu_init_display(struct vmw_private *dev_priv) 
	if (ret != 0)

		goto err_free;



	ret = drm_mode_create_dirty_info_property(dev);

	if (ret != 0)

		goto err_vblank_cleanup;



	vmw_kms_create_implicit_placement_property(dev_priv, true);



	if (dev_priv->capabilities & SVGA_CAP_MULTIMON)
@@ -439,8 +432,6 @@ int vmw_kms_ldu_init_display(struct vmw_private *dev_priv) 


	return 0;



err_vblank_cleanup:

	drm_vblank_cleanup(dev);

err_free:

	kfree(dev_priv->ldu_priv);

	dev_priv->ldu_priv = NULL;

drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c

+0 −11
Original line number Diff line number Diff line
@@ -537,9 +537,6 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit) 


	drm_mode_crtc_set_gamma_size(crtc, 256);



	drm_object_attach_property(&connector->base,

				   dev->mode_config.dirty_info_property,

				   1);

	drm_object_attach_property(&connector->base,

				   dev_priv->hotplug_mode_update_property, 1);

	drm_object_attach_property(&connector->base,
@@ -574,10 +571,6 @@ int vmw_kms_sou_init_display(struct vmw_private *dev_priv) 
	if (unlikely(ret != 0))

		return ret;



	ret = drm_mode_create_dirty_info_property(dev);

	if (unlikely(ret != 0))

		goto err_vblank_cleanup;



	vmw_kms_create_implicit_placement_property(dev_priv, false);



	for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i)
@@ -588,10 +581,6 @@ int vmw_kms_sou_init_display(struct vmw_private *dev_priv) 
	DRM_INFO("Screen Objects Display Unit initialized\n");



	return 0;



err_vblank_cleanup:

	drm_vblank_cleanup(dev);

	return ret;

}



int vmw_kms_sou_close_display(struct vmw_private *dev_priv)

CRA Git | Maintained and supported by SUSTech CRA and CCSE