Commit 6aaecd38 authored by Parav Pandit's avatar Parav Pandit Committed by Jason Gunthorpe
Browse files

RDMA/core: Simplify roce_resolve_route_from_path() 



Currently RoCE route resolve functionality is split between two
functions. (a) roce_resolve_route_from_path() and its helper function
rdma_resolve_ip_route().

Due to this multiple sockaddr src structures are created in both functions
with rdma_dev_addr is an interface between the two for checks.

Since there is only one user of rdma_resolve_ip_route() as RoCE, combine
the functionality of both functions to roce_resolve_route_from_path() and
further reduce the scope of rdma_dev_addr to core/addr.c

This also allow to extend addr_resolve() in subsequent patch to consider
netdev properties of GID in safer way under rcu lock.

Additionally src and dst addresses were always provided, so skip the src
addr NULL pointer check as they are present on the stack now.

Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent c31d4b2d

drivers/infiniband/core/addr.c

+38 −13
Original line number Diff line number Diff line
@@ -45,6 +45,7 @@ 
#include <net/addrconf.h>

#include <net/ip6_route.h>

#include <rdma/ib_addr.h>

#include <rdma/ib_sa.h>

#include <rdma/ib.h>

#include <rdma/rdma_netlink.h>

#include <net/netlink.h>
@@ -659,23 +660,47 @@ err: 
}

EXPORT_SYMBOL(rdma_resolve_ip);



int rdma_resolve_ip_route(struct sockaddr *src_addr,

			  const struct sockaddr *dst_addr,

			  struct rdma_dev_addr *addr)

int roce_resolve_route_from_path(struct sa_path_rec *rec,

				 const struct ib_gid_attr *attr)

{

	struct sockaddr_storage ssrc_addr = {};

	struct sockaddr *src_in = (struct sockaddr *)&ssrc_addr;

	union {

		struct sockaddr     _sockaddr;

		struct sockaddr_in  _sockaddr_in;

		struct sockaddr_in6 _sockaddr_in6;

	} sgid, dgid;

	struct rdma_dev_addr dev_addr = {};

	int ret;



	if (src_addr) {

		if (src_addr->sa_family != dst_addr->sa_family)

	if (rec->roce.route_resolved)

		return 0;



	rdma_gid2ip(&sgid._sockaddr, &rec->sgid);

	rdma_gid2ip(&dgid._sockaddr, &rec->dgid);



	if (sgid._sockaddr.sa_family != dgid._sockaddr.sa_family)

		return -EINVAL;



		memcpy(src_in, src_addr, rdma_addr_size(src_addr));

	} else {

		src_in->sa_family = dst_addr->sa_family;

	}

	if (!attr || !attr->ndev)

		return -EINVAL;



	dev_addr.bound_dev_if = attr->ndev->ifindex;

	/* TODO: Use net from the ib_gid_attr once it is added to it,

	 * until than, limit itself to init_net.

	 */

	dev_addr.net = &init_net;



	return addr_resolve(src_in, dst_addr, addr, false, 0);

	ret = addr_resolve(&sgid._sockaddr, &dgid._sockaddr,

			   &dev_addr, false, 0);

	if (ret)

		return ret;



	if ((dev_addr.network == RDMA_NETWORK_IPV4 ||

	     dev_addr.network == RDMA_NETWORK_IPV6) &&

	    rec->rec_type != SA_PATH_REC_TYPE_ROCE_V2)

		return -EINVAL;



	rec->roce.route_resolved = true;

	return 0;

}



/**

drivers/infiniband/core/core_priv.h

+3 −0
Original line number Diff line number Diff line
@@ -343,4 +343,7 @@ int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid, 
void rdma_copy_src_l2_addr(struct rdma_dev_addr *dev_addr,

			   const struct net_device *dev);



struct sa_path_rec;

int roce_resolve_route_from_path(struct sa_path_rec *rec,

				 const struct ib_gid_attr *attr);

#endif /* _CORE_PRIV_H */

drivers/infiniband/core/sa_query.c

+0 −40
Original line number Diff line number Diff line
@@ -1227,46 +1227,6 @@ static u8 get_src_path_mask(struct ib_device *device, u8 port_num) 
	return src_path_mask;

}



static int roce_resolve_route_from_path(struct sa_path_rec *rec,

					const struct ib_gid_attr *attr)

{

	struct rdma_dev_addr dev_addr = {};

	union {

		struct sockaddr     _sockaddr;

		struct sockaddr_in  _sockaddr_in;

		struct sockaddr_in6 _sockaddr_in6;

	} sgid_addr, dgid_addr;

	int ret;



	if (rec->roce.route_resolved)

		return 0;

	if (!attr || !attr->ndev)

		return -EINVAL;



	dev_addr.bound_dev_if = attr->ndev->ifindex;

	/* TODO: Use net from the ib_gid_attr once it is added to it,

	 * until than, limit itself to init_net.

	 */

	dev_addr.net = &init_net;



	rdma_gid2ip(&sgid_addr._sockaddr, &rec->sgid);

	rdma_gid2ip(&dgid_addr._sockaddr, &rec->dgid);



	/* validate the route */

	ret = rdma_resolve_ip_route(&sgid_addr._sockaddr,

				    &dgid_addr._sockaddr, &dev_addr);

	if (ret)

		return ret;



	if ((dev_addr.network == RDMA_NETWORK_IPV4 ||

	     dev_addr.network == RDMA_NETWORK_IPV6) &&

	    rec->rec_type != SA_PATH_REC_TYPE_ROCE_V2)

		return -EINVAL;



	rec->roce.route_resolved = true;

	return 0;

}



static int init_ah_attr_grh_fields(struct ib_device *device, u8 port_num,

				   struct sa_path_rec *rec,

				   struct rdma_ah_attr *ah_attr,

CRA Git | Maintained and supported by SUSTech CRA and CCSE