extcon: ptn5150: Fix usage of atomic GPIO with sleeping GPIO chips (6aaad58c) · Commits · 戴 / test

The driver uses atomic version of gpiod_set_value() without any real reason. It is called in a workqueue under mutex so it could sleep there. Changing it to "can_sleep" flavor allows to use the driver with all GPIO chips. Fixes: ("extcon: Add support for ptn5150 extcon driver") Cc: <stable@vger.kernel.org> Signed-off-by:

Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by:

Vijai Kumar K <vijaikumar.kanagarajan@gmail.com> Signed-off-by:

Chanwoo Choi <cw00.choi@samsung.com>

drivers/extcon/extcon-ptn5150.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -127,7 +127,7 @@ static void ptn5150_irq_work(struct work_struct *work)
		case PTN5150_DFP_ATTACHED:
		extcon_set_state_sync(info->edev,
		EXTCON_USB_HOST, false);
		gpiod_set_value(info->vbus_gpiod, 0);
		gpiod_set_value_cansleep(info->vbus_gpiod, 0);
		extcon_set_state_sync(info->edev, EXTCON_USB,
		true);
		break;
		@@ -138,9 +138,9 @@ static void ptn5150_irq_work(struct work_struct *work)
		PTN5150_REG_CC_VBUS_DETECTION_MASK) >>
		PTN5150_REG_CC_VBUS_DETECTION_SHIFT);
		if (vbus)
		gpiod_set_value(info->vbus_gpiod, 0);
		gpiod_set_value_cansleep(info->vbus_gpiod, 0);
		else
		gpiod_set_value(info->vbus_gpiod, 1);
		gpiod_set_value_cansleep(info->vbus_gpiod, 1);

		extcon_set_state_sync(info->edev,
		EXTCON_USB_HOST, true);
		@@ -156,7 +156,7 @@ static void ptn5150_irq_work(struct work_struct *work)
		EXTCON_USB_HOST, false);
		extcon_set_state_sync(info->edev,
		EXTCON_USB, false);
		gpiod_set_value(info->vbus_gpiod, 0);
		gpiod_set_value_cansleep(info->vbus_gpiod, 0);
		}
		}

Admin message