Commit 6a9a27d5 authored Apr 26, 2018 by Xin Long Committed by David S. Miller Apr 27, 2018

sctp: clear the new asoc's stream outcnt in sctp_stream_update



When processing a duplicate cookie-echo chunk, sctp moves the new
temp asoc's stream out/in into the old asoc, and later frees this
new temp asoc.

But now after this move, the new temp asoc's stream->outcnt is not
cleared while stream->out is set to NULL, which would cause a same
crash as the one fixed in Commit 79d08951 ("sctp: fix error
path in sctp_stream_init") when freeing this asoc later.

This fix is to clear this outcnt in sctp_stream_update.

Fixes: f952be79 ("sctp: introduce struct sctp_stream_out_ext")
Reported-by: Jianwen Ji <jiji@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9306b38e

net/sctp/stream.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -240,6 +240,8 @@ void sctp_stream_update(struct sctp_stream stream, struct sctp_stream new)

		new->out = NULL;
		new->in = NULL;
		new->outcnt = 0;
		new->incnt = 0;
		}

		static int sctp_send_reconf(struct sctp_association *asoc,

Admin message