net: sched: cls_bpf: rename cls_bpf_modify_existing function (6a725c48) · Commits · 戴 / test

The name cls_bpf_modify_existing is highly misleading, as it indeed does not modify anything existing. It does not modify at all. Signed-off-by:

net/sched/cls_bpf.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -382,10 +382,9 @@ static int cls_bpf_prog_from_efd(struct nlattr *tb, struct cls_bpf_prog prog,
		return 0;
		}

		static int cls_bpf_modify_existing(struct net net, struct tcf_proto tp,
		struct cls_bpf_prog *prog,
		unsigned long base, struct nlattr **tb,
		struct nlattr *est, bool ovr)
		static int cls_bpf_set_parms(struct net net, struct tcf_proto tp,
		struct cls_bpf_prog *prog, unsigned long base,
		struct nlattr *tb, struct nlattr est, bool ovr)
		{
		bool is_bpf, is_ebpf, have_exts = false;
		struct tcf_exts exts;
		@@ -508,8 +507,7 @@ static int cls_bpf_change(struct net net, struct sk_buff in_skb,
		goto errout;
		}

		ret = cls_bpf_modify_existing(net, tp, prog, base, tb, tca[TCA_RATE],
		ovr);
		ret = cls_bpf_set_parms(net, tp, prog, base, tb, tca[TCA_RATE], ovr);
		if (ret < 0)
		goto errout;