Commit 6a64d3cd authored by Oleksij Rempel's avatar Oleksij Rempel Committed by David S. Miller
Browse files

net: phy: tja11xx: add delayed registration of TJA1102 PHY1 



TJA1102 is a dual PHY package with PHY0 having proper PHYID and PHY1
having no ID. On one hand it is possible to for PHY detection by
compatible, on other hand we should be able to reset complete chip
before PHY1 configured it, and we need to define dependencies for proper
power management.

We can solve it by defining PHY1 as child of PHY0:
	tja1102_phy0: ethernet-phy@4 {
		reg = <0x4>;

		interrupts-extended = <&gpio5 8 IRQ_TYPE_LEVEL_LOW>;

		reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
		reset-assert-us = <20>;
		reset-deassert-us = <2000>;

		tja1102_phy1: ethernet-phy@5 {
			reg = <0x5>;

			interrupts-extended = <&gpio5 8 IRQ_TYPE_LEVEL_LOW>;
		};
	};

The PHY1 should be a subnode of PHY0 and registered only after PHY0 was
completely reset and initialized.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5972157c

drivers/net/phy/nxp-tja11xx.c

+105 −7
Original line number Diff line number Diff line
@@ -6,11 +6,14 @@ 
#include <linux/delay.h>

#include <linux/ethtool.h>

#include <linux/kernel.h>

#include <linux/mdio.h>

#include <linux/mii.h>

#include <linux/module.h>

#include <linux/phy.h>

#include <linux/hwmon.h>

#include <linux/bitfield.h>

#include <linux/of_mdio.h>

#include <linux/of_irq.h>



#define PHY_ID_MASK			0xfffffff0

#define PHY_ID_TJA1100			0x0180dc40
@@ -57,6 +60,8 @@ 
struct tja11xx_priv {

	char		*hwmon_name;

	struct device	*hwmon_dev;

	struct phy_device *phydev;

	struct work_struct phy_register_work;

};



struct tja11xx_phy_stats {
@@ -323,16 +328,12 @@ static const struct hwmon_chip_info tja11xx_hwmon_chip_info = { 
	.info		= tja11xx_hwmon_info,

};



static int tja11xx_probe(struct phy_device *phydev)

static int tja11xx_hwmon_register(struct phy_device *phydev,

				  struct tja11xx_priv *priv)

{

	struct device *dev = &phydev->mdio.dev;

	struct tja11xx_priv *priv;

	int i;



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	priv->hwmon_name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);

	if (!priv->hwmon_name)

		return -ENOMEM;
@@ -350,6 +351,103 @@ static int tja11xx_probe(struct phy_device *phydev) 
	return PTR_ERR_OR_ZERO(priv->hwmon_dev);

}



static int tja11xx_probe(struct phy_device *phydev)

{

	struct device *dev = &phydev->mdio.dev;

	struct tja11xx_priv *priv;



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	priv->phydev = phydev;



	return tja11xx_hwmon_register(phydev, priv);

}



static void tja1102_p1_register(struct work_struct *work)

{

	struct tja11xx_priv *priv = container_of(work, struct tja11xx_priv,

						 phy_register_work);

	struct phy_device *phydev_phy0 = priv->phydev;

	struct mii_bus *bus = phydev_phy0->mdio.bus;

	struct device *dev = &phydev_phy0->mdio.dev;

	struct device_node *np = dev->of_node;

	struct device_node *child;

	int ret;



	for_each_available_child_of_node(np, child) {

		struct phy_device *phy;

		int addr;



		addr = of_mdio_parse_addr(dev, child);

		if (addr < 0) {

			dev_err(dev, "Can't parse addr\n");

			continue;

		} else if (addr != phydev_phy0->mdio.addr + 1) {

			/* Currently we care only about double PHY chip TJA1102.

			 * If some day NXP will decide to bring chips with more

			 * PHYs, this logic should be reworked.

			 */

			dev_err(dev, "Unexpected address. Should be: %i\n",

				phydev_phy0->mdio.addr + 1);

			continue;

		}



		if (mdiobus_is_registered_device(bus, addr)) {

			dev_err(dev, "device is already registered\n");

			continue;

		}



		/* Real PHY ID of Port 1 is 0 */

		phy = phy_device_create(bus, addr, PHY_ID_TJA1102, false, NULL);

		if (IS_ERR(phy)) {

			dev_err(dev, "Can't create PHY device for Port 1: %i\n",

				addr);

			continue;

		}



		/* Overwrite parent device. phy_device_create() set parent to

		 * the mii_bus->dev, which is not correct in case.

		 */

		phy->mdio.dev.parent = dev;



		ret = of_mdiobus_phy_device_register(bus, phy, child, addr);

		if (ret) {

			/* All resources needed for Port 1 should be already

			 * available for Port 0. Both ports use the same

			 * interrupt line, so -EPROBE_DEFER would make no sense

			 * here.

			 */

			dev_err(dev, "Can't register Port 1. Unexpected error: %i\n",

				ret);

			phy_device_free(phy);

		}

	}

}



static int tja1102_p0_probe(struct phy_device *phydev)

{

	struct device *dev = &phydev->mdio.dev;

	struct tja11xx_priv *priv;

	int ret;



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;



	priv->phydev = phydev;

	INIT_WORK(&priv->phy_register_work, tja1102_p1_register);



	ret = tja11xx_hwmon_register(phydev, priv);

	if (ret)

		return ret;



	schedule_work(&priv->phy_register_work);



	return 0;

}



static int tja1102_match_phy_device(struct phy_device *phydev, bool port0)

{

	int ret;
@@ -433,7 +531,7 @@ static struct phy_driver tja11xx_driver[] = { 
	}, {

		.name		= "NXP TJA1102 Port 0",

		.features       = PHY_BASIC_T1_FEATURES,

		.probe		= tja11xx_probe,

		.probe		= tja1102_p0_probe,

		.soft_reset	= tja11xx_soft_reset,

		.config_init	= tja11xx_config_init,

		.read_status	= tja11xx_read_status,

CRA Git | Maintained and supported by SUSTech CRA and CCSE