Commit 6a570814 authored by Dean Jenkins's avatar Dean Jenkins Committed by David S. Miller
Browse files

asix: Continue processing URB if no RX netdev buffer 



Avoid a loss of synchronisation of the Ethernet Data header 32-bit
word due to a failure to get a netdev socket buffer.

The ASIX RX handling algorithm returned 0 upon a failure to get
an allocation of a netdev socket buffer. This causes the URB
processing to stop which potentially causes a loss of synchronisation
with the Ethernet Data header 32-bit word. Therefore, subsequent
processing of URBs may be rejected due to a loss of synchronisation.
This may cause additional good Ethernet frames to be discarded
along with outputting of synchronisation error messages.

Implement a solution which checks whether a netdev socket buffer
has been allocated before trying to copy the Ethernet frame into
the netdev socket buffer. But continue to process the URB so that
synchronisation is maintained. Therefore, only a single Ethernet
frame is discarded when no netdev socket buffer is available.

Signed-off-by: default avatarDean Jenkins <Dean_Jenkins@mentor.com>
Signed-off-by: default avatarMark Craske <Mark_Craske@mentor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3f30b158

drivers/net/usb/asix_common.c

+19 −12
Original line number Original line Diff line number Diff line
@@ -74,12 +74,14 @@ int asix_rx_fixup_internal(struct usbnet *dev, struct sk_buff *skb, 
		if (size != ((~rx->header >> 16) & 0x7ff)) {

		if (size != ((~rx->header >> 16) & 0x7ff)) {

			netdev_err(dev->net, "asix_rx_fixup() Data Header synchronisation was lost, remaining %d\n",

			netdev_err(dev->net, "asix_rx_fixup() Data Header synchronisation was lost, remaining %d\n",

				   rx->remaining);

				   rx->remaining);

			if (rx->ax_skb) {

				kfree_skb(rx->ax_skb);

				kfree_skb(rx->ax_skb);

				rx->ax_skb = NULL;

				rx->ax_skb = NULL;

			/* Discard the incomplete netdev Ethernet frame and

				/* Discard the incomplete netdev Ethernet frame

			 * assume the Data header is at the start of the current

				 * and assume the Data header is at the start of

			 * URB socket buffer.

				 * the current URB socket buffer.

				 */

				 */

			}

			rx->remaining = 0;

			rx->remaining = 0;

		}

		}

	}

	}
@@ -121,9 +123,12 @@ int asix_rx_fixup_internal(struct usbnet *dev, struct sk_buff *skb, 
				return 0;

				return 0;

			}

			}





			/* Sometimes may fail to get a netdev socket buffer but

			 * continue to process the URB socket buffer so that

			 * synchronisation of the Ethernet frame Data header

			 * word is maintained.

			 */

			rx->ax_skb = netdev_alloc_skb_ip_align(dev->net, size);

			rx->ax_skb = netdev_alloc_skb_ip_align(dev->net, size);

			if (!rx->ax_skb)

				return 0;





			rx->remaining = size;

			rx->remaining = size;

		}

		}
@@ -136,10 +141,12 @@ int asix_rx_fixup_internal(struct usbnet *dev, struct sk_buff *skb, 
			rx->remaining = 0;

			rx->remaining = 0;

		}

		}





		if (rx->ax_skb) {

			data = skb_put(rx->ax_skb, copy_length);

			data = skb_put(rx->ax_skb, copy_length);

			memcpy(data, skb->data + offset, copy_length);

			memcpy(data, skb->data + offset, copy_length);

			if (!rx->remaining)

			if (!rx->remaining)

				usbnet_skb_return(dev, rx->ax_skb);

				usbnet_skb_return(dev, rx->ax_skb);

		}





		offset += (copy_length + 1) & 0xfffe;

		offset += (copy_length + 1) & 0xfffe;

	}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE