Commit 6a39ab3b authored Nov 01, 2019 by Alexandru Ardelean Committed by Jonathan Cameron Nov 03, 2019

iio: imu: adis: check ret val for non-zero vs less-than-zero



The ADIS library functions return zero on success, and negative values for
error. Positive values aren't returned, but we only care about the success
value (which is zero).

This change is mostly needed so that the compiler won't make any inferences
about some about values being potentially un-initialized. This only
triggers after making some functions inline, because the compiler can
better follow return paths.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 92c7529f

drivers/iio/imu/adis.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -286,7 +286,7 @@ int adis_check_status(struct adis *adis)
		int i;

		ret = adis_read_reg_16(adis, adis->data->diag_stat_reg, &status);
		if (ret < 0)
		if (ret)
		return ret;

		status &= adis->data->status_error_mask;

Admin message