Commit 6a178497 authored Nov 06, 2020 by Lukas Bulwahn Committed by Stephen Boyd Nov 14, 2020

clk: remove unneeded dead-store initialization



make clang-analyzer on x86_64 defconfig caught my attention with:

  drivers/clk/clk.c:423:19:
  warning: Value stored to 'parent' during its initialization is never read
  [clang-analyzer-deadcode.DeadStores]
          struct clk_core *parent = ERR_PTR(-ENOENT);
                           ^

Commit fc0c209c ("clk: Allow parents to be specified without string
names") introduced clk_core_fill_parent_index() with this unneeded
dead-store initialization.

So, simply remove this unneeded dead-store initialization to make
clang-analyzer happy.

As compilers will detect this unneeded assignment and optimize this anyway,
the resulting object code is identical before and after this change.

No functional change. No change to object code.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Link: https://lore.kernel.org/r/20201106094820.30167-1-lukas.bulwahn@gmail.com


Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 3650b228

drivers/clk/clk.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -420,7 +420,7 @@ static struct clk_core clk_core_get(struct clk_core core, u8 p_index)
		static void clk_core_fill_parent_index(struct clk_core *core, u8 index)
		{
		struct clk_parent_map *entry = &core->parents[index];
		struct clk_core *parent = ERR_PTR(-ENOENT);
		struct clk_core *parent;

		if (entry->hw) {
		parent = entry->hw->core;

Admin message