Commit 6a0af224 authored Oct 13, 2020 by Pavel Begunkov Committed by Jens Axboe Oct 17, 2020

io_uring: don't put a poll req under spinlock



Move io_put_req() in io_poll_task_handler() from under spinlock. This
eliminates the need to use REQ_F_COMP_LOCKED, at the expense of
potentially having to grab the lock again. That's still a better trade
off than relying on the locked flag.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent b1b74cfc

fs/io_uring.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -4844,10 +4844,9 @@ static void io_poll_task_handler(struct io_kiocb req, struct io_kiocb *nxt)

		hash_del(&req->hash_node);
		io_poll_complete(req, req->result, 0);
		req->flags \|= REQ_F_COMP_LOCKED;
		*nxt = io_put_req_find_next(req);
		spin_unlock_irq(&ctx->completion_lock);

		*nxt = io_put_req_find_next(req);
		io_cqring_ev_posted(ctx);
		}

Admin message