Commit 69ea651c authored Aug 19, 2020 by Colin Ian King Committed by Paul Moore Aug 19, 2020

selinux: fix allocation failure check on newpolicy->sidtab



The allocation check of newpolicy->sidtab is null checking if
newpolicy is null and not newpolicy->sidtab. Fix this.

Addresses-Coverity: ("Logically dead code")
Fixes: c7c556f1 ("selinux: refactor changing booleans")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent c7c556f1

security/selinux/ss/services.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2224,7 +2224,7 @@ int security_load_policy(struct selinux_state state, void data, size_t len,
		return -ENOMEM;

		newpolicy->sidtab = kzalloc(sizeof(*newpolicy->sidtab), GFP_KERNEL);
		if (!newpolicy)
		if (!newpolicy->sidtab)
		goto err;

		rc = policydb_read(&newpolicy->policydb, fp);

Admin message