Commit 69d58839 authored Jun 04, 2014 by Nishanth Menon Committed by Mark Brown Jun 05, 2014

regulator: core: print error value when constraints are not applied



With commit 064d5cd1
(regulator: core: Fix the init of DT defined fixed regulators)
We ensure that regulator must be capable of providing it's current
voltage when constraints are used, however adding the return value in
the print is a little more informative to explain the nature of the
failure involved.

So, instead of providing message such as:
smps9: failed to get the current voltage

having error value added to the message such as:
smps9: failed to get the current voltage(-22)

is a little more informative for debugging the error.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent 978371cb

drivers/regulator/core.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -846,7 +846,9 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
		rdev->constraints->min_uV == rdev->constraints->max_uV) {
		int current_uV = _regulator_get_voltage(rdev);
		if (current_uV < 0) {
		rdev_err(rdev, "failed to get the current voltage\n");
		rdev_err(rdev,
		"failed to get the current voltage(%d)\n",
		current_uV);
		return current_uV;
		}
		if (current_uV < rdev->constraints->min_uV \|\|
		@@ -856,8 +858,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
		rdev->constraints->max_uV);
		if (ret < 0) {
		rdev_err(rdev,
		"failed to apply %duV constraint\n",
		rdev->constraints->min_uV);
		"failed to apply %duV constraint(%d)\n",
		rdev->constraints->min_uV, ret);
		return ret;
		}
		}

Admin message