Commit 69bf5313 authored Aug 27, 2018 by Tomas Winkler Committed by Greg Kroah-Hartman Sep 12, 2018

mei: bus: fix hw module get/put balance

In case the device is not connected it doesn't 'get'
hw module and hence should not 'put' it on disable.

Cc: <stable@vger.kernel.org> 4.16+
Fixes:'commit 257355a4 ("mei: make module referencing local to the bus.c")'
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200455


Tested-by: Georg Müller <georgmueller@gmx.net>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c1a214ad

drivers/misc/mei/bus.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -616,9 +616,8 @@ int mei_cldev_disable(struct mei_cl_device *cldev)
		if (err < 0)
		dev_err(bus->dev, "Could not disconnect from the ME client\n");

		out:
		mei_cl_bus_module_put(cldev);

		out:
		/* Flush queues and remove any pending read */
		mei_cl_flush_queues(cl, NULL);
		mei_cl_unlink(cl);

Admin message