Commit 69be8f18 authored by Steven Rostedt's avatar Steven Rostedt Committed by Linus Torvalds
Browse files

[PATCH] convert signal handling of NODEFER to act like other Unix boxes. 



It has been reported that the way Linux handles NODEFER for signals is
not consistent with the way other Unix boxes handle it.  I've written a
program to test the behavior of how this flag affects signals and had
several reports from people who ran this on various Unix boxes,
confirming that Linux seems to be unique on the way this is handled.

The way NODEFER affects signals on other Unix boxes is as follows:

1) If NODEFER is set, other signals in sa_mask are still blocked.

2) If NODEFER is set and the signal is in sa_mask, then the signal is
still blocked. (Note: this is the behavior of all tested but Linux _and_
NetBSD 2.0 *).

The way NODEFER affects signals on Linux:

1) If NODEFER is set, other signals are _not_ blocked regardless of
sa_mask (Even NetBSD doesn't do this).

2) If NODEFER is set and the signal is in sa_mask, then the signal being
handled is not blocked.

The patch converts signal handling in all current Linux architectures to
the way most Unix boxes work.

Unix boxes that were tested:  DU4, AIX 5.2, Irix 6.5, NetBSD 2.0, SFU
3.5 on WinXP, AIX 5.3, Mac OSX, and of course Linux 2.6.13-rcX.

* NetBSD was the only other Unix to behave like Linux on point #2. The
main concern was brought up by point #1 which even NetBSD isn't like
Linux.  So with this patch, we leave NetBSD as the lonely one that
behaves differently here with #2.

Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 02b3e4e2

arch/alpha/kernel/signal.c

+5 −6
Original line number Diff line number Diff line
@@ -566,14 +566,13 @@ handle_signal(int sig, struct k_sigaction *ka, siginfo_t *info, 
	if (ka->sa.sa_flags & SA_RESETHAND)

		ka->sa.sa_handler = SIG_DFL;



	if (!(ka->sa.sa_flags & SA_NODEFER)) {

	spin_lock_irq(&current->sighand->siglock);

	sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);

	if (!(ka->sa.sa_flags & SA_NODEFER)) 

		sigaddset(&current->blocked,sig);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

}

}



static inline void

syscall_restart(unsigned long r0, unsigned long r19,

arch/arm/kernel/signal.c

+3 −2
Original line number Diff line number Diff line
@@ -658,10 +658,11 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, 
	/*

	 * Block the signal if we were unsuccessful.

	 */

	if (ret != 0 || !(ka->sa.sa_flags & SA_NODEFER)) {

	if (ret != 0) {

		spin_lock_irq(&tsk->sighand->siglock);

		sigorsets(&tsk->blocked, &tsk->blocked,

			  &ka->sa.sa_mask);

		if (!(ka->sa.sa_flags & SA_NODEFER))

			sigaddset(&tsk->blocked, sig);

		recalc_sigpending();

		spin_unlock_irq(&tsk->sighand->siglock);

arch/arm26/kernel/signal.c

+6 −7
Original line number Diff line number Diff line
@@ -454,14 +454,13 @@ handle_signal(unsigned long sig, siginfo_t *info, sigset_t *oldset, 
		if (ka->sa.sa_flags & SA_ONESHOT)

			ka->sa.sa_handler = SIG_DFL;



		if (!(ka->sa.sa_flags & SA_NODEFER)) {

		spin_lock_irq(&tsk->sighand->siglock);

		sigorsets(&tsk->blocked, &tsk->blocked,

			  &ka->sa.sa_mask);

		if (!(ka->sa.sa_flags & SA_NODEFER))

			sigaddset(&tsk->blocked, sig);

		recalc_sigpending();

		spin_unlock_irq(&tsk->sighand->siglock);

		}

		return;

	}

arch/cris/arch-v10/kernel/signal.c

+5 −6
Original line number Diff line number Diff line
@@ -517,14 +517,13 @@ handle_signal(int canrestart, unsigned long sig, 
	if (ka->sa.sa_flags & SA_ONESHOT)

		ka->sa.sa_handler = SIG_DFL;



	if (!(ka->sa.sa_flags & SA_NODEFER)) {

	spin_lock_irq(&current->sighand->siglock);

	sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);

	if (!(ka->sa.sa_flags & SA_NODEFER))

		sigaddset(&current->blocked,sig);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

}

}



/*

 * Note that 'init' is a special process: it doesn't get signals it doesn't

arch/cris/arch-v32/kernel/signal.c

+5 −6
Original line number Diff line number Diff line
@@ -568,14 +568,13 @@ handle_signal(int canrestart, unsigned long sig, 
	if (ka->sa.sa_flags & SA_ONESHOT)

		ka->sa.sa_handler = SIG_DFL;



	if (!(ka->sa.sa_flags & SA_NODEFER)) {

	spin_lock_irq(&current->sighand->siglock);

	sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);

	if (!(ka->sa.sa_flags & SA_NODEFER))

		sigaddset(&current->blocked,sig);

	recalc_sigpending();

	spin_unlock_irq(&current->sighand->siglock);

}

}



/*

 * Note that 'init' is a special process: it doesn't get signals it doesn't

CRA Git | Maintained and supported by SUSTech CRA and CCSE