mm, compaction: skip rechecks when lock was already held (69b7189f) · Commits · 戴 / test

Compaction scanners try to lock zone locks as late as possible by checking many page or pageblock properties opportunistically without lock and skipping them if not unsuitable. For pages that pass the initial checks, some properties have to be checked again safely under lock. However, if the lock was already held from a previous iteration in the initial checks, the rechecks are unnecessary. This patch therefore skips the rechecks when the lock was already held. This is now possible to do, since we don't (potentially) drop and reacquire the lock between the initial checks and the safe rechecks anymore. Signed-off-by:

Vlastimil Babka <vbabka@suse.cz> Reviewed-by:

Zhang Yanfei <zhangyanfei@cn.fujitsu.com> Reviewed-by:

Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Acked-by:

Minchan Kim <minchan@kernel.org> Acked-by:

Mel Gorman <mgorman@suse.de> Cc: Michal Nazarewicz <mina86@mina86.com> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Cc: Christoph Lameter <cl@linux.com> Cc: Rik van Riel <riel@redhat.com> Acked-by:

David Rientjes <rientjes@google.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

mm/compaction.c

+31 −22

Original line number	Diff line number	Diff line
		@@ -366,6 +366,14 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
		if (!PageBuddy(page))
		goto isolate_fail;

		/*
		* If we already hold the lock, we can skip some rechecking.
		* Note that if we hold the lock now, checked_pageblock was
		* already set in some previous iteration (or strict is true),
		* so it is correct to skip the suitable migration target
		* recheck as well.
		*/
		if (!locked) {
		/*
		* The zone lock must be held to isolate freepages.
		* Unfortunately this is a very coarse lock and can be
		@@ -374,7 +382,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
		* spin on the lock and we acquire the lock as late as
		* possible.
		*/
		if (!locked)
		locked = compact_trylock_irqsave(&cc->zone->lock,
		&flags, cc);
		if (!locked)
		@@ -383,6 +390,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
		/* Recheck this is a buddy page under lock */
		if (!PageBuddy(page))
		goto isolate_fail;
		}

		/* Found a free page, break it into order-0 pages */
		isolated = split_free_page(page);
		@@ -644,8 +652,8 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
		page_count(page) > page_mapcount(page))
		continue;

		/* If the lock is not held, try to take it */
		if (!locked)
		/* If we already hold the lock, we can skip some rechecking */
		if (!locked) {
		locked = compact_trylock_irqsave(&zone->lru_lock,
		&flags, cc);
		if (!locked)
		@@ -658,6 +666,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
		low_pfn += (1 << compound_order(page)) - 1;
		continue;
		}
		}

		lruvec = mem_cgroup_page_lruvec(page, zone);

Admin message