Commit 699cc876 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Alexander Graf
Browse files

kvm: powerpc: book3s: Add is_hv_enabled to kvmppc_ops 



This help us to identify whether we are running with hypervisor mode KVM
enabled. The change is needed so that we can have both HV and PR kvm
enabled in the same kernel.

If both HV and PR KVM are included, interrupts come in to the HV version
of the kvmppc_interrupt code, which then jumps to the PR handler,
renamed to kvmppc_interrupt_pr, if the guest is a PR guest.

Allowing both PR and HV in the same kernel required some changes to
kvm_dev_ioctl_check_extension(), since the values returned now can't
be selected with #ifdefs as much as previously. We look at is_hv_enabled
to return the right value when checking for capabilities.For capabilities that
are only provided by HV KVM, we return the HV value only if
is_hv_enabled is true. For capabilities provided by PR KVM but not HV,
we return the PR value only if is_hv_enabled is false.

NOTE: in later patch we replace is_hv_enabled with a static inline
function comparing kvm_ppc_ops

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
parent dd96b2c2

arch/powerpc/include/asm/kvm_book3s.h

+0 −53
Original line number Diff line number Diff line
@@ -301,59 +301,6 @@ static inline ulong kvmppc_get_fault_dar(struct kvm_vcpu *vcpu) 
	return vcpu->arch.fault_dar;

}



#ifdef CONFIG_KVM_BOOK3S_PR_POSSIBLE



static inline unsigned long kvmppc_interrupt_offset(struct kvm_vcpu *vcpu)

{

	return to_book3s(vcpu)->hior;

}



static inline void kvmppc_update_int_pending(struct kvm_vcpu *vcpu,

			unsigned long pending_now, unsigned long old_pending)

{

	if (pending_now)

		vcpu->arch.shared->int_pending = 1;

	else if (old_pending)

		vcpu->arch.shared->int_pending = 0;

}



static inline bool kvmppc_critical_section(struct kvm_vcpu *vcpu)

{

	ulong crit_raw = vcpu->arch.shared->critical;

	ulong crit_r1 = kvmppc_get_gpr(vcpu, 1);

	bool crit;



	/* Truncate crit indicators in 32 bit mode */

	if (!(vcpu->arch.shared->msr & MSR_SF)) {

		crit_raw &= 0xffffffff;

		crit_r1 &= 0xffffffff;

	}



	/* Critical section when crit == r1 */

	crit = (crit_raw == crit_r1);

	/* ... and we're in supervisor mode */

	crit = crit && !(vcpu->arch.shared->msr & MSR_PR);



	return crit;

}

#else /* CONFIG_KVM_BOOK3S_PR_POSSIBLE */



static inline unsigned long kvmppc_interrupt_offset(struct kvm_vcpu *vcpu)

{

	return 0;

}



static inline void kvmppc_update_int_pending(struct kvm_vcpu *vcpu,

			unsigned long pending_now, unsigned long old_pending)

{

}



static inline bool kvmppc_critical_section(struct kvm_vcpu *vcpu)

{

	return false;

}

#endif



/* Magic register values loaded into r3 and r4 before the 'sc' assembly

 * instruction for the OSI hypercalls */

#define OSI_SC_MAGIC_R3			0x113724FA

arch/powerpc/include/asm/kvm_ppc.h

+3 −2
Original line number Diff line number Diff line
@@ -180,6 +180,7 @@ union kvmppc_one_reg { 
};



struct kvmppc_ops {

	bool is_hv_enabled;

	int (*get_sregs)(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs);

	int (*set_sregs)(struct kvm_vcpu *vcpu, struct kvm_sregs *sregs);

	int (*get_one_reg)(struct kvm_vcpu *vcpu, u64 id,
@@ -309,10 +310,10 @@ static inline void kvmppc_set_xics_phys(int cpu, unsigned long addr) 


static inline u32 kvmppc_get_xics_latch(void)

{

	u32 xirr = get_paca()->kvm_hstate.saved_xirr;

	u32 xirr;



	xirr = get_paca()->kvm_hstate.saved_xirr;

	get_paca()->kvm_hstate.saved_xirr = 0;



	return xirr;

}

arch/powerpc/kvm/book3s.c

+44 −0
Original line number Diff line number Diff line
@@ -69,6 +69,50 @@ void kvmppc_core_load_guest_debugstate(struct kvm_vcpu *vcpu) 
{

}



static inline unsigned long kvmppc_interrupt_offset(struct kvm_vcpu *vcpu)

{

	if (!kvmppc_ops->is_hv_enabled)

		return to_book3s(vcpu)->hior;

	return 0;

}



static inline void kvmppc_update_int_pending(struct kvm_vcpu *vcpu,

			unsigned long pending_now, unsigned long old_pending)

{

	if (kvmppc_ops->is_hv_enabled)

		return;

	if (pending_now)

		vcpu->arch.shared->int_pending = 1;

	else if (old_pending)

		vcpu->arch.shared->int_pending = 0;

}



static inline bool kvmppc_critical_section(struct kvm_vcpu *vcpu)

{

	ulong crit_raw;

	ulong crit_r1;

	bool crit;



	if (kvmppc_ops->is_hv_enabled)

		return false;



	crit_raw = vcpu->arch.shared->critical;

	crit_r1 = kvmppc_get_gpr(vcpu, 1);



	/* Truncate crit indicators in 32 bit mode */

	if (!(vcpu->arch.shared->msr & MSR_SF)) {

		crit_raw &= 0xffffffff;

		crit_r1 &= 0xffffffff;

	}



	/* Critical section when crit == r1 */

	crit = (crit_raw == crit_r1);

	/* ... and we're in supervisor mode */

	crit = crit && !(vcpu->arch.shared->msr & MSR_PR);



	return crit;

}



void kvmppc_inject_interrupt(struct kvm_vcpu *vcpu, int vec, u64 flags)

{

	vcpu->arch.shared->srr0 = kvmppc_get_pc(vcpu);

arch/powerpc/kvm/book3s_hv.c

+1 −0
Original line number Diff line number Diff line
@@ -2159,6 +2159,7 @@ static long kvm_arch_vm_ioctl_hv(struct file *filp, 
}



static struct kvmppc_ops kvmppc_hv_ops = {

	.is_hv_enabled = true,

	.get_sregs = kvm_arch_vcpu_ioctl_get_sregs_hv,

	.set_sregs = kvm_arch_vcpu_ioctl_set_sregs_hv,

	.get_one_reg = kvmppc_get_one_reg_hv,

arch/powerpc/kvm/book3s_pr.c

+1 −0
Original line number Diff line number Diff line
@@ -1523,6 +1523,7 @@ static long kvm_arch_vm_ioctl_pr(struct file *filp, 
}



static struct kvmppc_ops kvmppc_pr_ops = {

	.is_hv_enabled = false,

	.get_sregs = kvm_arch_vcpu_ioctl_get_sregs_pr,

	.set_sregs = kvm_arch_vcpu_ioctl_set_sregs_pr,

	.get_one_reg = kvmppc_get_one_reg_pr,

CRA Git | Maintained and supported by SUSTech CRA and CCSE