Commit 69738cfd authored Nov 29, 2019 by Deepa Dinamani Committed by Steve French Dec 02, 2019

fs: cifs: Fix atime update check vs mtime

According to the comment in the code and commit log, some apps
expect atime >= mtime; but the introduced code results in
atime==mtime.  Fix the comparison to guard against atime<mtime.

Fixes: 9b9c5bea ("cifs: do not return atime less than mtime")
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: stfrench@microsoft.com
Cc: linux-cifs@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 6f582b27

fs/cifs/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -163,7 +163,7 @@ cifs_fattr_to_inode(struct inode inode, struct cifs_fattr fattr)

		spin_lock(&inode->i_lock);
		/* we do not want atime to be less than mtime, it broke some apps */
		if (timespec64_compare(&fattr->cf_atime, &fattr->cf_mtime))
		if (timespec64_compare(&fattr->cf_atime, &fattr->cf_mtime) < 0)
		inode->i_atime = fattr->cf_mtime;
		else
		inode->i_atime = fattr->cf_atime;

Admin message