Commit 695e38d8 authored Sep 18, 2017 by Mathieu Malaterre Committed by Alexandre Belloni Oct 12, 2017

rtc: jz4740: fix loading of rtc driver

The current timeout for waiting for WRDY is not always sufficient. Always
increase it to 10000 even on JZ4740. This is technically only required on
JZ4780, where the current symptoms seen after a hard reboot are:

jz4740-rtc 10003000.rtc: rtc core: registered 10003000.rtc as rtc0
jz4740-rtc 10003000.rtc: Could not write to RTC registers
jz4740-rtc: probe of 10003000.rtc failed with error -5

Suggested-by: Alex Smith <alex.smith@imgtec.com>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 49de9828

drivers/rtc/rtc-jz4740.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -82,7 +82,7 @@ static inline uint32_t jz4740_rtc_reg_read(struct jz4740_rtc *rtc, size_t reg)
		static int jz4740_rtc_wait_write_ready(struct jz4740_rtc *rtc)
		{
		uint32_t ctrl;
		int timeout = 1000;
		int timeout = 10000;

		do {
		ctrl = jz4740_rtc_reg_read(rtc, JZ_REG_RTC_CTRL);
		@@ -94,7 +94,7 @@ static int jz4740_rtc_wait_write_ready(struct jz4740_rtc *rtc)
		static inline int jz4780_rtc_enable_write(struct jz4740_rtc *rtc)
		{
		uint32_t ctrl;
		int ret, timeout = 1000;
		int ret, timeout = 10000;

		ret = jz4740_rtc_wait_write_ready(rtc);
		if (ret != 0)

Admin message