Commit 692d8363 authored Oct 10, 2020 by Pavel Begunkov Committed by Jens Axboe Oct 10, 2020

io_uring: don't delay io_init_req() error check



Don't postpone io_init_req() error checks and do that right after
calling it. There is no control-flow statements or dependencies with
sqe/submitted accounting, so do those earlier, that makes the code flow
a bit more natural.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 062d04d7

fs/io_uring.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -6466,12 +6466,11 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr)
		submitted = -EAGAIN;
		break;
		}

		err = io_init_req(ctx, req, sqe, &state);
		io_consume_sqe(ctx);
		/* will complete beyond this point, count as submitted */
		submitted++;

		err = io_init_req(ctx, req, sqe, &state);
		if (unlikely(err)) {
		fail_req:
		io_put_req(req);

Admin message