Commit 69218a48 authored Mar 21, 2016 by Lior David Committed by Kalle Valo Apr 04, 2016

wil6210: allow empty WMI commands in debugfs wmi_send



There are many valid WMI commands with only header without any
additional payload. Such WMI commands could not be sent using
the debugfs wmi_send facility. Fix the code to allow sending
of such commands.

Signed-off-by: Lior David <qca_liord@qca.qualcomm.com>
Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 7b9bc799

drivers/net/wireless/ath/wil6210/debugfs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -832,7 +832,7 @@ static ssize_t wil_write_file_wmi(struct file file, const char __user buf,
		u16 cmdid;
		int rc, rc1;

		if (cmdlen <= 0)
		if (cmdlen < 0)
		return -EINVAL;

		wmi = kmalloc(len, GFP_KERNEL);
		@@ -845,7 +845,7 @@ static ssize_t wil_write_file_wmi(struct file file, const char __user buf,
		return rc;
		}

		cmd = &wmi[1];
		cmd = (cmdlen > 0) ? &wmi[1] : NULL;
		cmdid = le16_to_cpu(wmi->command_id);

		rc1 = wmi_send(wil, cmdid, cmd, cmdlen);

Admin message