Commit 68f73a1b authored Mar 10, 2020 by Wambui Karuga Committed by Daniel Vetter Mar 18, 2020

drm/omap: remove checks for return value of drm_debugfs functions

Since 987d65d0 (drm: debugfs: make
drm_debugfs_create_files() never fail), there is no need to ever check
the return value for drm_debugfs_create_files(). Therefore remove the
checks for the return value and subsequent error handling in
omap_debugfs_init().

These changes also enables the changing of omap_debugfs_init() to return
0 directly.

v2: convert omap_debugfs_init() to return 0 instead of void to avoid
introduction of build issues and enable individual driver compilation.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html


Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-14-wambui.karugax@gmail.com

parent b4441251

drivers/gpu/drm/omapdrm/omap_debugfs.c

+7 −20

Original line number	Diff line number	Diff line
		@@ -82,29 +82,16 @@ static struct drm_info_list omap_dmm_debugfs_list[] = {

		int omap_debugfs_init(struct drm_minor *minor)
		{
		struct drm_device *dev = minor->dev;
		int ret;

		ret = drm_debugfs_create_files(omap_debugfs_list,
		drm_debugfs_create_files(omap_debugfs_list,
		ARRAY_SIZE(omap_debugfs_list),
		minor->debugfs_root, minor);

		if (ret) {
		dev_err(dev->dev, "could not install omap_debugfs_list\n");
		return ret;
		}

		if (dmm_is_available())
		ret = drm_debugfs_create_files(omap_dmm_debugfs_list,
		drm_debugfs_create_files(omap_dmm_debugfs_list,
		ARRAY_SIZE(omap_dmm_debugfs_list),
		minor->debugfs_root, minor);

		if (ret) {
		dev_err(dev->dev, "could not install omap_dmm_debugfs_list\n");
		return ret;
		}

		return ret;
		return 0;
		}

		#endif

Admin message