dma-debug: debugfs_create_bool() takes a u32 pointer (68ee6d22) · Commits · 戴 / test

Even though it has "bool" in the name, you have pass a u32 pointer to debugfs_create_bool(). Otherwise you get memory corruption in write_file_bool(). Fortunately in this case the corruption happens in an alignment hole between variables so it doesn't cause any problems. Signed-off-by:

Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:

Joerg Roedel <joerg.roedel@amd.com>

lib/dma-debug.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -78,7 +78,7 @@ static LIST_HEAD(free_entries);
		static DEFINE_SPINLOCK(free_entries_lock);

		/* Global disable flag - will be set in case of an error */
		static bool global_disable __read_mostly;
		static u32 global_disable __read_mostly;

		/* Global error count */
		static u32 error_count;
		@@ -657,7 +657,7 @@ static int dma_debug_fs_init(void)

		global_disable_dent = debugfs_create_bool("disabled", 0444,
		dma_debug_dent,
		(u32 *)&global_disable);
		&global_disable);
		if (!global_disable_dent)
		goto out_err;

Admin message